Skip to content

Fix Windows long-path expectation in symlink unit test - #723

Merged
sophiecarreras merged 2 commits into
masterfrom
codex/612-windows-path-comparison
Nov 22, 2026
Merged

sophiecarreras merged 2 commits into
masterfrom
codex/612-windows-path-comparison

Conversation

@sophiecarreras

@sophiecarreras sophiecarreras commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Check the exact path returned through a symlinked root and internal symlink, accounting for the SDK's established Windows long-path prefix. The newer filesystem-identity assertions from master (#724/#725) remain intact alongside the exact-path assertion. The outside-root rejection check, production code, skip conditions and workflows are unchanged. Includes the required changelog fragment.

Related: https://github.com/backblaze-labs/quality-keeper/issues/612 (keep open).

Validation:

  • Shared TDD policy: the original Windows failure was an incorrect expectation, as established by the utility contract and neighboring traversal tests. The later merge conflict was resolved by retaining both sets of checks; no production behavior changed or artificial red was introduced.
  • After merging master, focused scan tests passed for every API: v3/v2 each 41 passed, 6 skipped; v1/v0 each 40 passed, 7 skipped. Ruff, changed-file formatting and whitespace checks passed.
  • Fresh CI run 44971608369 succeeded at conflict-resolution head a61132cc4cf7e030c19464f2fb10f7df6d99ec80: 24 jobs passed, including all five Windows CPython 3.10–3.14 jobs. All 21 SDK/CLI live steps were skipped; cleanup was skipped with zero steps executed.

Live tests and bucket cleanup remain disabled (B2_LIVE_TESTS_ENABLED=false). Snyk is excluded as requested.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@sophiecarreras
sophiecarreras marked this pull request as ready for review November 22, 2026 01:36
@sophiecarreras
sophiecarreras merged commit 3811cd5 into master Nov 22, 2026
28 checks passed
@sophiecarreras
sophiecarreras deleted the codex/612-windows-path-comparison branch November 22, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant