Skip to content

test: drop unused known-defect imports after the low-severity fixes - #722

Merged
ffumero2003 merged 1 commit into
masterfrom
fix-python-prune-unused-known-defect-imports
Nov 21, 2026
Merged

ffumero2003 merged 1 commit into
masterfrom
fix-python-prune-unused-known-defect-imports

Conversation

@ffumero2003

Copy link
Copy Markdown
Contributor

Context

Merging the low-severity fixes (#716, #719) converted several @known_defect xfail tests into ordinary assertions but left test.known_defect imports unused, so ruff check fails on master with three F401 errors.

Changes

  • test/unit/bucket/test_regression_bucket.py: import only expect, known_defect (drop DefectStillPresent).
  • test/unit/stream/test_regression_streams.py: import only expect (drop DefectStillPresent, known_defect).

Verification

  • Confirmed the kept names are still referenced in each file; the dropped names are not.

Refs #711

Merging the low-severity fixes (#716, #719) converted known-defect tests
to ordinary assertions but left test.known_defect imports unused, failing
ruff (F401) on master. Import only the names each module still uses.

Refs #711
@ffumero2003 ffumero2003 self-assigned this Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The bucket and stream regression test modules remove unused imports from test.known_defect. A changelog entry records the cleanup.

Merge Risk: Minimal · up to eb848

This cleanup removes unused test imports that trigger lint errors and does not change production behavior. It carries no meaningful merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: removing unused test.known_defect imports after the low-severity fixes. The raw summary and objectives confirm that the three test files only drop unused imports, so t…
Description check Passed The description states the context (low-severity fixes left unused imports and caused three Ruff F401 errors on master), lists the per-file import changes, and gives a verification note. It matches th…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: removing unused test.known_defect imports after the low-severity fixes. The raw summary and objectives confirm that the three test files only drop unused imports, so the title matches the changeset.

Full details: Description check

Explanation

The description states the context (low-severity fixes left unused imports and caused three Ruff F401 errors on master), lists the per-file import changes, and gives a verification note. It matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5541d290-fabe-4cfd-97b8-1fc7cea295c1
Commits

Reviewing files that changed from the base of the PR and between 2e316e6 and eb8484d.

Files selected for processing: 3

  • changelog.d/+prune-unused-known-defect-imports.infrastructure.md
  • test/unit/bucket/test_regression_bucket.py
  • test/unit/stream/test_regression_streams.py

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@ffumero2003
ffumero2003 merged commit f9bad63 into master Nov 21, 2026
24 of 29 checks passed
@ffumero2003
ffumero2003 deleted the fix-python-prune-unused-known-defect-imports branch November 21, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant