Repository navigation
Extend the browser harness to the film's playback primitives - #42
Merged
Merged
Conversation
The film's pause, replay, disclosure and reduced-motion behavior were only covered by manual review. Add them to the headless Chrome check: three described scenes, initial autoplay, pause/play labels, info disclosure and Escape, replay reset, six Tab stops with visible outlines, and a frozen phase-3 start under reduced motion where replay stays paused.\n\nRename the script to check-playground-browser and the CI job to browser-check because it now covers both surfaces. Update the harness descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The experiment's DOM primitives were pinned in #37, #41 and #36, but the film's playback primitives were still only checked by hand: autoplay, pause/play labels, replay, the info disclosure, Escape, and the reduced-motion frozen start.
What changed
npm run test:browserto check the builtindex.htmlafter the experiment checks.hidden/aria-expandedpair, Escape pausing and closing, and replay resetting to phase 0.solid 2pxoutlines.scripts/check-playground-browser.mjsand the workflow job tobrowser-check; updates the harness descriptions.Verification
npm run test:browser— exit 0 in Chrome 157; film and experiment checks passnpm run check— exit 0, 145 unit tests, 5 integration tests, package and bundle checksBoundary
This is a DOM and keyboard regression check. It does not establish screen-reader behavior, visual-design quality or comprehension. Issue #16 remains open.