Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logout cleared persisted authentication but left the current authenticator logged in when a custom redirect handler ran. A return URI configured with
setReturnUri()was sent only asu, so the provider did not use it as the logout destination.Clear both the stored authentication and in-memory user/session data before redirecting. Send the configured return URI in the encrypted
redirectTofield already supported by the provider. An explicitlogout($redirectTo)takes priority; without either setting, retain the provider's default destination. Keep unrelated session data and the default fake user's local-only logout behaviour. Document destination precedence in the README and remove the obsolete logout TODO.The return override is now optional internally, preserving the existing current-request fallback for login and profile URI generation while distinguishing an explicitly configured logout return destination.
Closes #19.
Validation
e76a2a2commits two regression tests first, verified failing on master: stale identity at redirect time and missing encrypted destination.ebe7c96implements the fix and expands destination coverage (configured return, explicit path/URI/query override, provider default).composer test: 63 tests, 147 assertions; PHPStan level 6, PHP_CodeSniffer and PHPMD pass locally on PHP 8.5.admin-interface--new-flairlogout handlers: both already accept encryptedredirectTo, so no provider change or branch merge is needed.No live browser/provider deployment test was performed; the regression checks cover client state, encryption and the outgoing provider contract. GitHub CI checks PHP 8.4 and PHP 8.5.