Skip to content

fix(collabs): stop track edits deleting pending collaborator invites - #14785

Merged
dylanjeffers merged 1 commit into
mainfrom
fix/collab-invites-dropped
Nov 13, 2026
Merged

dylanjeffers merged 1 commit into
mainfrom
fix/collab-invites-dropped

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Reported on the Lifted track `schloob-x-abasin-munchd`: one invite vanished, and the accepted collaborator showed as "Invite Pending".

Cause

  • The indexer reconciles invites against the `collaborators` list on every track update that sends one, and deletes anyone not in it.
  • `pending_collaborators` only comes back when the track is fetched as its owner. The cached track is often fetched without a user id (first page load) so it has none.
  • Every update path sent the cached list: the edit forms, bulk edit, and make-public. Saving any edit could delete pending invites.
  • The web modal rendered "Invite Pending" for every row with no check.

Changes

  • New `useTrackCollaboratorsForEdit`: fetches accepted + pending as the owner, uncached. Web edit page and mobile edit screen wait for it before seeding the form.
  • Bulk edit and make-public no longer send `collaborators`, so the indexer leaves invites alone.
  • Web modal shows "Accepted" for accepted collaborators.

Testing

Lint, typecheck and common tests pass. Not exercised in the running app; needs an account that owns a track with a pending invite.

Related: AudiusProject/api user search fix (zero-follower artists could not be found to invite).

🤖 Generated with Claude Code

The indexer drops any collaborator missing from the list an update sends.
Pending invites only come back on a request made as the owner, so a cached
track often lacks them and saving an edit removed the invite. The edit forms
now load the list as the owner, and bulk edit and make-public leave the list
out. The web modal also labels accepted collaborators as accepted.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5d0192c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers
dylanjeffers merged commit e16a859 into main Nov 13, 2026
27 checks passed
@dylanjeffers
dylanjeffers deleted the fix/collab-invites-dropped branch November 13, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant