Repository navigation
fix(web/chat): keep composer inside the chat column as it grows - #14784
Merged
Merged
Conversation
The message list sizes itself against a hardcoded 88px --chat-composer-height, so a multi-line message or a link preview made the composer overflow below the column and behind the play bar. Measure the composer with a ResizeObserver and set the variable on the chat area, keeping the list pinned to the newest message if it was there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
On desktop web Messages, the message list scrolls behind the frosted composer using
--chat-composer-height, hardcoded to 88px on.chatArea. The list never shrinks, so once the composer grows past 88px (more than ~2 lines of text, or a track/collection link preview) it overflows below the chat column and behind the play bar. On prod with 5 lines the composer bottom was at 953px while the column ended at 858px.Fix
ChatPagemeasures the composer with a ResizeObserver and sets--chat-composer-heighton the chat area, so the list's negative margin and padding follow the real height. The 88px CSS value stays as the fallback and is restored when the composer unmounts.ChatComposerandFrostednow forward refs (Frosted diff is mostly re-indentation).MobileChatPageearly, so it is untouched.Verified
tsc --noEmit -p packages/web: no errors in web (3 errors inpackages/sdkcame from a stale localspldist, unrelated).Not verified
🤖 Generated with Claude Code