Skip to content

fix(ci): stamp the desktop release version with node, not jq - #14759

Merged
dylanjeffers merged 1 commit into
mainfrom
fix/desktop-stamp-version-without-jq
Nov 11, 2026
Merged

dylanjeffers merged 1 commit into
mainfrom
fix/desktop-stamp-version-without-jq

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Summary

Linux and Windows desktop builds have failed on every production release since #14751, so the Linux AppImage crash fix (#14746, issue #14745) hasn't reached users.

#14751 added a "Stamp release version" step that uses jq. The Linux and Windows desktop jobs run in the electronuserland/builder container, which doesn't include jq:

/__w/_temp/….sh: 2: jq: not found
##[error]Process completed with exit code 127.

Both releases approved on Nov 7 (42342550410, 42417045539) shipped web and Mac but failed Linux and Windows at this step. Mac runs on a macOS runner, which has jq.

Change

The stamp step now uses node -e (already set up in every desktop job) instead of jq. The step is changed in all three desktop jobs so they stay identical. The remaining jq calls are in jobs on ubuntu-latest and macOS runners.

Testing

  • On the current packages/web/package.json, the Node command writes byte-for-byte the same file as the old jq --arg v … '.version = $v' command.
  • The workflow YAML parses.
  • The desktop jobs only run after the production gate on main, so this can't be exercised on the PR. The next approved release will confirm it.

— 🏹 Legolas

🤖 Generated with Claude Code

#14751 added a Stamp release version step that runs jq, but the Linux
and Windows desktop jobs run in the electronuserland/builder container,
which has no jq. Both jobs exit 127 on every approved release since
(runs 42342550410 and 42417045539), so the Linux AppImage fix (#14746)
has not reached users. Mac runs on a macOS runner and is unaffected.

The node one-liner writes the same package.json bytes as the jq command.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dylanjeffers dylanjeffers added the bug Something isn't working label Nov 9, 2026
@changeset-bot

changeset-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e9cdbd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

@dylanjeffers
dylanjeffers merged commit 100c43c into main Nov 11, 2026
18 checks passed
@dylanjeffers
dylanjeffers deleted the fix/desktop-stamp-version-without-jq branch November 11, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant