Skip to content

fix(api): hide new notification types from clients that can't parse them - #1073

Merged
dylanjeffers merged 1 commit into
mainfrom
fix/notifications-opt-in-types
Nov 12, 2026
Merged

dylanjeffers merged 1 commit into
mainfrom
fix/notifications-opt-in-types

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Notifications stopped loading on web and mobile this afternoon.

The generated SDK's NotificationFromJSONTyped throws on any type it doesn't know, so the whole response is rejected. Today's weekly_rotation_featured (#1069), weekly_artist_recap (#1070) and trending_genre (#1071) aren't in the SDK on any shipped client (or on apps main), and clients don't pass types, so any user with one of those rows got an empty list.

These three types are now returned (and counted in unread_count) only when the caller includes them in types. Everything else is unchanged.

The client still needs a follow-up: regenerate the SDK and request these types explicitly, and stop one unknown type from failing the whole page.

Test: TestV1Notifications_OptInTypesHiddenUnlessRequested (fails without the fix).

🤖 Generated with Claude Code

The generated SDK throws on an unknown notification type, which fails the
whole page. weekly_rotation_featured, weekly_artist_recap and trending_genre
broke the notification list on every shipped web and mobile client. Return
them only when the caller lists them in `types`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dylanjeffers
dylanjeffers merged commit 702b4f7 into main Nov 12, 2026
@dylanjeffers
dylanjeffers deleted the fix/notifications-opt-in-types branch November 12, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant