Skip to content

feat(api): track feedback requests - #1068

Merged
dylanjeffers merged 2 commits into
mainfrom
feat/track-feedback-requests
Nov 11, 2026
Merged

dylanjeffers merged 2 commits into
mainfrom
feat/track-feedback-requests

Conversation

@dylanjeffers

@dylanjeffers dylanjeffers commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Backend for "looking for feedback" on tracks (indexer side: OpenAudio/go-openaudio#625).

  • Migration 0243 adds tracks.feedback_requested_at (nullable) and a partial index for live rows where it's set. CREATE INDEX CONCURRENTLY, no transaction. Almost every row is NULL, so the index is tiny.
  • Track responses gain feedback_requested (bool) and feedback_requested_at.
  • GET /v1/tracks/feedback: tracks asking for feedback, newest request first, with limit/offset/genre. Uses the same filters as /tracks/latest (no deleted, unlisted, unavailable or deactivated-owner tracks), and also skips tracks that are stream-gated, use access authorities, or have comments disabled, since nobody could hear them or leave feedback.
  • feedback_requested accepted on POST/PUT /tracks request bodies; swagger updated.
  • sql/01_schema.sql updated to match.

Also bumps go-openaudio (root + pkg/etl) to 17aab31, which includes OpenAudio/go-openaudio#625, so the indexer writes the column on merge. No release needed; both are pseudo-versions.

No protocol change. api only uses SignManageEntity, RecoverPubkeyFromCoreTx and the chain ID / address constants from core, and none of them changed. The mainnet upgrade schedule is unchanged (AttestationDomainHeight is deliberately unset there). The proto change adds an optional canon field that defaults to false, which api never sets. ETL migrations 0040 and 0041 are IF NOT EXISTS no-ops here, and 0041 uses the same index name as ddl 0243.

The pkg/etl move from Aug 18 also brings indexer-side fixes: email_access.is_initial, the access_authorities projection, the default playlist_contents add-time, only the owner can edit a comment, and a signer check on comment mute.

Test plan

  • New tests in v1_tracks_feedback_test.go: ordering by request time, unlisted / comments-disabled / deactivated-owner excluded, genre + paging, and a track without the flag returns feedback_requested: false
  • go test ./api/... against a DB built from this branch's schema. Only failure is TestFeedScheduledReleases, which fails the same way on origin/main.

🤖 Generated with Claude Code

dylanjeffers and others added 2 commits November 11, 2026 12:22
Adds tracks.feedback_requested_at (set by the indexer from track metadata),
returns feedback_requested / feedback_requested_at on tracks, accepts
feedback_requested on track create/update, and adds GET /v1/tracks/feedback
listing tracks asking for feedback, newest request first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dylanjeffers
dylanjeffers force-pushed the feat/track-feedback-requests branch from 7bc5fd7 to 4ecb08d Compare November 11, 2026 20:28
@dylanjeffers
dylanjeffers merged commit 0ae65e4 into main Nov 11, 2026
@dylanjeffers
dylanjeffers deleted the feat/track-feedback-requests branch November 11, 2026 21:19
dylanjeffers added a commit to AudiusProject/apps that referenced this pull request Nov 11, 2026
…#14750)

## Summary

Artists can ask for feedback on a track. Listeners leave it as ordinary
timestamped comments, which pairs with the feed waveform comment box in
#14736. Behind `track_feedback_requests` (on in dev, off in prod).

Backend: AudiusProject/api#1068 (field + `GET /v1/tracks/feedback`) and
OpenAudio/go-openaudio#625 (indexer).

- **Toggle:** "Looking for Feedback" in the track's advanced settings,
web and mobile, below Disable Comments. It's hidden for unlisted tracks
and when comments are off. Turning comments off also turns feedback off.
- **Tag:** "Feedback Wanted" on web track tiles, the web track page,
mobile track tiles, and the mobile track screen badges.
- **Explore:** a "Looking for Feedback" carousel (web desktop, mobile
web, mobile app), newest request first, hidden when empty.
- **SDK:** `feedbackRequested` on `Track` and the create/update bodies,
`feedbackRequested` in the upload/update metadata schema, and
`tracks.getFeedbackTracks`. Generated files were hand-trimmed to just
these changes. A full regen against the current spec also pulls in
unrelated drift (waveform, notification models).
- The track adapter only sends `feedback_requested` when it's set, so
other edit flows never clear it by accident.

## Test plan

- [x] `tsc --noEmit` for sdk, common and web (only errors are existing
Solana `ClaimableTokensProgram` ones from the local spl build); mobile
tsc has no errors in changed files
- [x] eslint on changed files
- [x] Local web build against prod with the flag override on and
`/v1/tracks/feedback` stubbed in the page (the endpoint isn't live yet):
the Explore carousel loads from the new endpoint, tiles show Feedback
Wanted, and the track page header shows it next to TRACK
- [ ] Edit form toggle, signed in on a track you own (not checked: no
signed-in session in the local build)
- [ ] Mobile toggle, tile tag, track screen badge and Explore section on
a device or simulator (not checked)

Before turning the flag on in prod: api#1068 deployed, and the api
bumped to a go-openaudio that includes #625.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant