Repository navigation
feat(api): track feedback requests - #1068
Merged
Merged
Conversation
Merged
3 of 5 tasks
Adds tracks.feedback_requested_at (set by the indexer from track metadata), returns feedback_requested / feedback_requested_at on tracks, accepts feedback_requested on track create/update, and adds GET /v1/tracks/feedback listing tracks asking for feedback, newest request first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dylanjeffers
force-pushed
the
feat/track-feedback-requests
branch
from
November 11, 2026 20:28
7bc5fd7 to
4ecb08d
Compare
dylanjeffers
added a commit
to AudiusProject/apps
that referenced
this pull request
Nov 11, 2026
…#14750) ## Summary Artists can ask for feedback on a track. Listeners leave it as ordinary timestamped comments, which pairs with the feed waveform comment box in #14736. Behind `track_feedback_requests` (on in dev, off in prod). Backend: AudiusProject/api#1068 (field + `GET /v1/tracks/feedback`) and OpenAudio/go-openaudio#625 (indexer). - **Toggle:** "Looking for Feedback" in the track's advanced settings, web and mobile, below Disable Comments. It's hidden for unlisted tracks and when comments are off. Turning comments off also turns feedback off. - **Tag:** "Feedback Wanted" on web track tiles, the web track page, mobile track tiles, and the mobile track screen badges. - **Explore:** a "Looking for Feedback" carousel (web desktop, mobile web, mobile app), newest request first, hidden when empty. - **SDK:** `feedbackRequested` on `Track` and the create/update bodies, `feedbackRequested` in the upload/update metadata schema, and `tracks.getFeedbackTracks`. Generated files were hand-trimmed to just these changes. A full regen against the current spec also pulls in unrelated drift (waveform, notification models). - The track adapter only sends `feedback_requested` when it's set, so other edit flows never clear it by accident. ## Test plan - [x] `tsc --noEmit` for sdk, common and web (only errors are existing Solana `ClaimableTokensProgram` ones from the local spl build); mobile tsc has no errors in changed files - [x] eslint on changed files - [x] Local web build against prod with the flag override on and `/v1/tracks/feedback` stubbed in the page (the endpoint isn't live yet): the Explore carousel loads from the new endpoint, tiles show Feedback Wanted, and the track page header shows it next to TRACK - [ ] Edit form toggle, signed in on a track you own (not checked: no signed-in session in the local build) - [ ] Mobile toggle, tile tag, track screen badge and Explore section on a device or simulator (not checked) Before turning the flag on in prod: api#1068 deployed, and the api bumped to a go-openaudio that includes #625. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backend for "looking for feedback" on tracks (indexer side: OpenAudio/go-openaudio#625).
tracks.feedback_requested_at(nullable) and a partial index for live rows where it's set.CREATE INDEX CONCURRENTLY, no transaction. Almost every row is NULL, so the index is tiny.feedback_requested(bool) andfeedback_requested_at.GET /v1/tracks/feedback: tracks asking for feedback, newest request first, withlimit/offset/genre. Uses the same filters as/tracks/latest(no deleted, unlisted, unavailable or deactivated-owner tracks), and also skips tracks that are stream-gated, use access authorities, or have comments disabled, since nobody could hear them or leave feedback.feedback_requestedaccepted onPOST/PUT /tracksrequest bodies; swagger updated.sql/01_schema.sqlupdated to match.Also bumps go-openaudio (root +
pkg/etl) to 17aab31, which includes OpenAudio/go-openaudio#625, so the indexer writes the column on merge. No release needed; both are pseudo-versions.No protocol change. api only uses
SignManageEntity,RecoverPubkeyFromCoreTxand the chain ID / address constants from core, and none of them changed. The mainnet upgrade schedule is unchanged (AttestationDomainHeightis deliberately unset there). The proto change adds an optionalcanonfield that defaults to false, which api never sets. ETL migrations 0040 and 0041 areIF NOT EXISTSno-ops here, and 0041 uses the same index name as ddl 0243.The
pkg/etlmove from Aug 18 also brings indexer-side fixes:email_access.is_initial, theaccess_authoritiesprojection, the defaultplaylist_contentsadd-time, only the owner can edit a comment, and a signer check on comment mute.Test plan
v1_tracks_feedback_test.go: ordering by request time, unlisted / comments-disabled / deactivated-owner excluded, genre + paging, and a track without the flag returnsfeedback_requested: falsego test ./api/...against a DB built from this branch's schema. Only failure isTestFeedScheduledReleases, which fails the same way onorigin/main.🤖 Generated with Claude Code