Repository navigation
Dev release: pin one engine snapshot for both packages and record it in the wheels - #305
Merged
Merged
Conversation
…in the wheels (closes #304) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304
A dev release embeds one pinned upstream snapshot in both packages, and each wheel says which.
scripts/dev_engine_pin.jsonnames the snapshot: image index digest, timestamped snapshot version, and the sha256 of everyarcadedb-*.jarin the image. Captured withscripts/dev_engine_pin.py capture. Today the image jars (amd64 and arm64) and the Sonatype jars are byte for byte the same (checkpasses).scripts/dev_engine_pin.py check --tag Truns in the first job of both release workflows and again after the native build.verify-jarsruns in the JVM jobs on the jars downloaded from the image, which is now pulled by digest for a dev tag.A.B.C.devNof the pinned base may link a snapshot. A final or.postNrelease refuses it, and another snapshot is refused for a dev release.tests/test_dev_engine_pin.pyruns the real plan step oftest-native.ymlfor these cases._version.py(JVM) and_build_info.py(native) recordENGINE_SNAPSHOTandENGINE_IMAGE_DIGEST, exported fromarcadedb. A JVM build records them only when its jars are the pinned ones.release.adocdescribe the dev pre-release and the pin. The native notices comparison stays skipped for a snapshot engine, which the docs now say.Checked locally: compile, black, isort, pyflakes, bandit, the plan step for six cases,
checkfor a dev and a final tag. The workflow runs and the test file run in CI.🤖 Generated with Claude Code