Repository navigation
Antalya 25.8 Backport of #131963 - Clear --jwt and the other credential options from the command line of clickhouse-client and clickhouse-keeper-client - #2935
Draft
blau-ai wants to merge 2 commits into
Conversation
…ptions-from-command-line Clear `--jwt` and the other credential options from the command line of `clickhouse-client` and `clickhouse-keeper-client` Conflicts committed as-is, conflict markers included: - programs/keeper-client/KeeperClient.cpp (both modified)
Resolved the keeper-client include conflict and trimmed the test to the options antalya-25.8 supports.
Collaborator
Author
|
Port-AL: cherry-pick conflicts resolved by AI Conflicted files:
Commits:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
clickhouse-clientnow clears the values of--jwt,--ssh-key-passphrase,--one-time-passwordand--oauth-client-secretfrom its command line, as it already did for--password, so they are no longer visible inpsand/proc/<pid>/cmdline.clickhouse-keeper-clientnow does the same for--passwordand--identity. Closes ClickHouse#131191. (ClickHouse#131963 by @groeneai)Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: