Repository navigation
Conversation
…armTaskAdmission` The gtests copied the lock protocol instead of calling the read-task callback path, so they did not check the production decision. Both now call the same function, so the tests exercise the code that decides whether a task request is sent. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swarm gtests copied the lock-then-send sequence into the test lambda, so they checked
SharedMutexrather than the decision the read-task callback makes.Context::runWithSwarmTaskAdmissionis that decision: it holds the admission lock across the enabled check and the send, then releases the lock before returning.TCPHandlerand the gtests both call it.StorageObjectStorageSwarm.*passes with--gtest_repeat=2.Related: #2759
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Test the swarm task admission decision through the same function the read-task callback uses.
Documentation entry for user-facing changes
None.
CI/CD Options
Exclude tests:
Regression jobs to run: