Repository navigation
Antalya 26.3 Backport of #131963 - Clear --jwt and the other credential options from the command line of clickhouse-client and clickhouse-keeper-client - #2930
Conversation
…ptions-from-command-line Clear `--jwt` and the other credential options from the command line of `clickhouse-client` and `clickhouse-keeper-client`
CI triage for 17d6e42Summary: 7 failing checks. 1 is caused by this PR (4 stateless jobs, all the same new test). 5 are infra or unrelated to this PR. DCO is a process check.
🔴
|
|
@blau-ai fix fails caused by this PR here |
…antalya-26.3 clickhouse-client clickhouse-client in this branch has no --oauth-client-secret option, so every client invocation in the test exited with an unrecognized-option error before connecting, and reading /proc/<pid>/cmdline failed.
|
Pushed a fix: c13bea4 Caused by this PR:
|
| Check | Evidence |
|---|---|
| Integration tests (amd_binary 1/5, amd_asan db disk old analyzer 7/8) | Whole modules (test_grpc_protocol, test_storage_mongodb, test_database_iceberg, test_storage_s3_queue, …) fail in cluster.start(): the docker image pull times out (helpers/cluster.py:3513, run_and_check(images_pull_cmd, timeout=600)). This is an infra problem. |
| Stress test (amd_ubsan) | Cannot start clickhouse-server: the Hybrid table test_1.t3 can't attach on restart because test_1.local_hot does not exist (UNKNOWN_TABLE). This is a Hybrid-engine table-load-order problem and has nothing to do with clearing credentials from argv. |
| Regression release swarms, DCO, Grype | Not related to the code in this PR. I did not look deeper into the swarms failure. |
CI on the new head still needs to confirm the fix.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
clickhouse-clientnow clears the values of--jwt,--ssh-key-passphrase,--one-time-passwordand--oauth-client-secretfrom its command line, as it already did for--password, so they are no longer visible inpsand/proc/<pid>/cmdline.clickhouse-keeper-clientnow does the same for--passwordand--identity. Closes ClickHouse#131191. (ClickHouse#131963 by @groeneai)Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: