Skip to content

[PWGUD] Cast to int64_t before multiplication #18579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekryshen merged 1 commit into from
Nov 4, 2026
Merged

[PWGUD] Cast to int64_t before multiplication #18579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions PWGUD/TableProducer/upcCandProducerBarrel.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ using SignalRef = std::pair<int32_t, int16_t>;
using DistanceMap = std::vector<std::vector<uint32_t>>;

DistanceMap buildMinimumDistanceMap(std::vector<uint32_t> const& tfIDs,
int64_t bcSOR, int32_t nBCsPerTF,
int64_t bcSOR, int64_t nBCsPerTF,
std::vector<int64_t>& activeBCs, uint32_t maxDistance,
bool skipFirstExactMatch = false)
{
Expand All @@ -101,8 +101,10 @@ DistanceMap buildMinimumDistanceMap(std::vector<uint32_t> const& tfIDs,
// The forward-only cursor makes the scan linear after sorting
size_t nextIndex = 0;
for (size_t iTF = 0; iTF < tfIDs.size(); ++iTF) {
const int64_t tfStartBC = bcSOR + tfIDs[iTF] * nBCsPerTF;
for (int64_t bcInTF = 0; bcInTF < nBCsPerTF; ++bcInTF) { // TODO why int64_t
// Cast before multiplication to prevent 32-bit integer overflow.
const int64_t tfStartBC = bcSOR + static_cast<int64_t>(tfIDs[iTF]) * nBCsPerTF;
// Use int64_t to keep BC arithmetic in 64 bits without additional casts.
for (int64_t bcInTF = 0; bcInTF < nBCsPerTF; ++bcInTF) {
const int64_t currentBC = tfStartBC + bcInTF;
while (nextIndex < activeBCs.size() && activeBCs[nextIndex] < currentBC) {
++nextIndex;
Expand Down
Loading