Skip to content

[PWGCF] Revert "[PWGCF] Add MFT-MFT correlation task" - #18563

Open
jgrosseo wants to merge 1 commit into
masterfrom
revert-18485-mftcorrelation
Open

jgrosseo wants to merge 1 commit into
masterfrom
revert-18485-mftcorrelation

Conversation

@jgrosseo

@jgrosseo jgrosseo commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Reverts #18485

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 170 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Revert "[PWGCF] Add MFT-MFT correlation task" [PWGCF] Revert "[PWGCF] Add MFT-MFT correlation task" Nov 3, 2026
@alibuild

alibuild commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e5d2148 at 2026-11-03 11:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 28 errors and 50 warnings.'
Found 28 errors and 50 warnings.
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/6737eccc9ca2b29a6a8c5f2211fcb7777379f0ab/O2Physics-code-check/errors.txt
PWGCF/Core/CorrelationContainer.cxx:158:4: error: C-style casts are discouraged; use const_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:198:6: error: C-style casts are discouraged; use const_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:209:34: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:209:34: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:426:16: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:526:57: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:634:7: error: Value stored to 'mixedNormError' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:731:25: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:731:25: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:769:18: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:839:20: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:839:20: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:939:32: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1013:14: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1013:14: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1023:14: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1023:14: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1173:19: error: redundant cast to the same type [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1173:19: error: redundant explicit casting to the same type 'TH1D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1174:17: error: redundant cast to the same type [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1174:17: error: redundant explicit casting to the same type 'TH3D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1179:19: error: redundant cast to the same type [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1179:19: error: redundant explicit casting to the same type 'TH1D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1180:17: error: redundant cast to the same type [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1180:17: error: redundant explicit casting to the same type 'TH3D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1433:23: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1433:23: error: do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:1576:13: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
++ [[ 50 -gt 0 ]]
++ cat /sw/BUILD/6737eccc9ca2b29a6a8c5f2211fcb7777379f0ab/O2Physics-code-check/warnings.txt
PWGCF/Core/CorrelationContainer.cxx:51:48: warning: initializer for base class 'TNamed' is redundant [readability-redundant-member-init]
PWGCF/Core/CorrelationContainer.cxx:66:64: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Core/CorrelationContainer.cxx:93:116: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Core/CorrelationContainer.cxx:134:1: warning: constructor does not initialize these fields: mEventCount [cppcoreguidelines-pro-type-member-init]
PWGCF/Core/CorrelationContainer.cxx:148:93: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Core/CorrelationContainer.cxx:209:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants