Repository navigation
[Common] Add LPMProduction to mc generator map to autodetect generator from metadata in the MultModule - #18549
Merged
Merged
Conversation
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
jesgum
changed the title
jesgum
marked this pull request as ready for review
November 2, 2026 10:06
jesgum
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo,
ktf and
victor-gonzalez
as code owners
November 2, 2026 10:06
dsekihat
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from specifying the MC generator as a configurable to auto detect based on the metadata. The specific generator is yet to be added so for we have to rely on a by-hand map from the LPMProduction to to the generator.
Most productions uses PYTHIA so we let that be the default case. Other productions with different generators (e.g. EPOS) will have to be looked up.
Once the generator information is added to the metadata, older productions would still need to be manually mapped
tagging @ddobrigk