Repository navigation
Android emulator tests: make the AVD where the emulator looks for it - #829
Merged
Merged
Conversation
Release run 43251862764's emulator exited at once: "Unknown AVD name [tslang_api29_x86_64] ... no file tslang_api29_x86_64.ini in $HOME/.android/avd". The runner's avdmanager had made it elsewhere. The run job sets ANDROID_USER_HOME and ANDROID_AVD_HOME for both, and the install step checks that `emulator -list-avds` names the AVD. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s tests PR #829's run booted the emulator and passed everything but two tester tests, 00class_override_arity and 00optional_union_truthiness, under every model: both came after v0.0-pre-alpha124 with the compiler fixes they check (#811, #815). When the job takes a published release's package, it now takes that release's tslang/test/tester/tests and CMakeLists.txt too; the runner and its skips stay the commit's own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 43251862764 (alpha125) failed in Run Android tests. The new start step now shows why the emulator exits:
The runner's
avdmanagermade the AVD somewhere the emulator doesn't search.Change
ANDROID_USER_HOMEandANDROID_AVD_HOMEto one directory in the workspace, soavdmanagerand the emulator both use it.emulator -list-avdsnames the AVD. If it doesn't, the step lists that directory and fails.Second commit: a published package runs with its own release's tests
The first commit's run booted the emulator in about 25 s. Every leg passed except two tester tests, under every model:
00class_override_arityand00optional_union_truthiness. Both were added after v0.0-pre-alpha124, together with the compiler fixes they check (#811, #815). The published compiler fails them, as it should.When the job uses a published release's package (a PR or a manual run), it now also checks out that release's
tslang/test/tester/testsandCMakeLists.txt. The runner and its skips stay this commit's, since they are what's being tested. A release run (package: artifact) is unchanged: its compiler and tests come from the same commit.Testing
This PR changes the workflow, so its CI builds the tests and boots the emulator with the newest published package. Please let that run finish before merging: the last two PRs merged before their emulator runs got that far.
🤖 Generated with Claude Code