Repository navigation
Radar palette vendor - #140
Conversation
zssherman
left a comment
zssherman
left a comment
There was a problem hiding this comment.
Do we need all of this if we already licence for ARM and this is from within our group? All this vendor code and docs?
|
@zssherman you have a point, I think we can just make them sub-modules of cmac_radar.py (and such). No need for a separate license, since it's all a contribution anyways. |
|
@rcjackson Yeah I would just double check with Scott. I would understand of we were pulling code from outside our group. |
|
The main reason for this is that RPM builds do not support pip only packages on the ADC, so all code for VAPs must be in conda-forge. I do not think radar-palette will be in conda-forge considering its experimental nature, so the relevant code should be contributed here. |
65e794d to
5525a20
Compare
|
I am happy with whatever makes sense. This was essentially authored in my "spare time" as a testing of agentic capabilities. I am happy with a straight copy rather than radar-pallette being on conda-forge. It is a palette of paints to make new things out of! I agree on the experimental state |
scollis
left a comment
scollis
left a comment
There was a problem hiding this comment.
As I said in the comment, cleared to proceed from me.
|
@zssherman now the needed radar_palette routines are just a separate sub-module of cmac |
| carry the strongest discriminating power. | ||
| """ | ||
|
|
||
| from __future__ import annotations |
There was a problem hiding this comment.
I dont think this is being used in most of this as there is no function or variable annotations
There was a problem hiding this comment.
Sounds like it's something the AI just put in. I've removed it.
|
@rcjackson Can you check the other files as well? I see it in most of them |
Vendoring @scollis 's radar-palette gate ID code into CMAC to ensure no dependence on pip only packages.
Written with assistance from GPT-5.6 Luna.