Skip to content

fix(jade): load the plugin on a dedicated server - #138

Merged
adamico merged 8 commits into
mainfrom
claude/implement-137-25ec71
Nov 6, 2026
Merged

adamico merged 8 commits into
mainfrom
claude/implement-137-25ec71

Conversation

@adamico

@adamico adamico commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Jade drops VoidworksJadePlugin on a dedicated server: its own methods drew tooltips, so verifying it pulled in net.minecraft.client.gui.*, and no Jade line backed by server data showed. The drawing moves into a nested Client, which a server never loads.

 VoidworksJadePlugin            # loaded on server and client
   register(common)             # server data providers
   registerClient(client)
-    9 lambdas + showDragon     # name ITooltip / Element
+    Client.register(client)
+  Client                       # client-only, nested
+    register(client)
+    lines(getter)              # one helper adding most machine reports' lines
+    showDragon(...)

Also makes the seen-loading game tests deterministic. Both tests chained onto one static VoidDragon.onPassing hook, and each put back the hook it found when it stopped. So when loads started first and stopped first, it threw away unloads' listener, and unloads timed out with "nothing is seen moving" (seen on CI: one run of a commit failed, the other passed). The hook is now set once while any test listens, and it hands each item moving to the test listening for that dragon.

And pins the dev client's gearworks 0.1.0 → 0.2.2 and groundworks 0.5.12 → 0.7.0, which are no longer in ~/.m2 (runClient failed at syncClientMods).

Evidence

  • Before: VoidworksJadePluginTest (load the plugin through a classloader refusing net.minecraft.client.*) fails with NoClassDefFoundError: net/minecraft/client/gui/layouts/LayoutElement. On a NeoForge 26.1.2.77 dedicated server with Jade 26.1.11 and Voidworks 0.2.1: Failed to load plugin from Voidworks ... Trying to load plugins again without erroneous plugins.
    After: the test passes. The same server with this branch's jar logs Start loading plugin from Voidworks and no error; a dev client joining it sees the Voidstone's network and the Mutation Chamber's payment in Jade. javap on the plugin class: no Jade tooltip or net/minecraft/client type. build and all 308 game tests pass; the full game-test suite passed 10 runs of 10 with the hook fix, at 5d42d42.

Merge Danger

Door: two-way

Blast Radius: none

No API or behaviour a Consumer sees changes beyond the Jade lines appearing on servers. The pin bump only changes the dev client's mods.

Closes #137

🤖 Generated with Claude Code

adamico and others added 8 commits November 6, 2026 10:20
Move how the reports are drawn out of VoidworksJadePlugin into
VoidworksJadeClient, so the plugin class names none of Jade's tooltip
types and verifies without the client's classes. A JUnit test loads it
through a classloader that refuses net.minecraft.client.

Closes #137

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The client half is VoidworksJadePlugin.Client, as the package's other
reports nest theirs, so the reports stay private. One helper adds a
report's lines, and the test's loader reports a read failure as a
ClassNotFoundException.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…local repo

gearworks 0.1.0 and groundworks 0.5.12 are no longer in ~/.m2, so
runClient failed at syncClientMods. Gearworks 0.2.2 nests the same
libworks-runtime as the Module; Groundworks 0.7.0's breaking changes
touch none of the Assembly data the Module declares.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each Shown saved the hook it found and set it back on stopping, so when
the loading test started first and stopped first it set back the
original hook and dropped the unloading test's, which then never heard
its item move and timed out. The hook is now set once while any test
listens and hands each passing to the one listening for its dragon, so
the order the tests start and end in no longer matters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shown.stop now removes its entry only if it is still the one listening
for its dragon, and does nothing before listen or a second time, so it
can never set back a hook it did not take. hear looks the record up by
the listener's dragon, and the hook's Javadoc says what a test that
fails before stopping leaves behind.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shown.listen throws if it already listens, or if another listens for
the same dragon, and stop throws if it is not listening, where both
went quietly on. hear unwraps its listener once, and stop has its
Javadoc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
listen says whether it already listens or another listens for that
dragon, and the hook it sets back is marked nullable, as its id is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamico
adamico enabled auto-merge (squash) November 6, 2026 10:30
@adamico
adamico merged commit e26f3e5 into main Nov 6, 2026
6 checks passed
@adamico
adamico deleted the claude/implement-137-25ec71 branch November 6, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Jade plugin fails to load on a dedicated server

1 participant