Repository navigation
Conversation
Closes #87 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paragraphs and headings can opt into text selection with
select-textor a literalclass="select-text".<a href>works inside and outside paragraphs, with named Link nodes, retained keyboard focus, Enter activation, and pointer targets over the actual wrapped text runs. Dragging selects without following the link, and copy preserves painted text and whitespace.Single-slash app paths use the current window's router. HTTP(S), mailto and tel use
open_url; protocol-relative URLs, whitespace/control characters, backslashes and other schemes are rejected on native and Web. Link and selection styling use the existing semantic primary/selection tokens. Base owns selection; its small adapter and copy changes are recorded invendor/gpui-base/RAKE-PATCH.md.Adds the link-name lint and generated guides, parser/href/interaction regressions, a selectable linked paragraph and standalone link in the view example, and updates
docs/view.md.Closes #87
Validation:
rake-app-cli; all 49 lint unit tests passed, including the new rule and generated-artifact checks.cargo test -p rake-view-syntax --lib: 27 passed.cargo test -p rake-ui --features test-support --lib: 12 passed, including key-up duplication, wrapped-row activation, drag-versus-click, styled-run copy, whitespace, and visible-only truncated copy.rake-view --features devtoolsbuild and worktree CLI Web build passed. No toolchain/package installs; an existing matching wasm-bindgen binary was used.rake ctl: accessible names, managed focus, Tab focus in a rendered capture, focus background, pointer/keyboard dispatch, theme switching, and exact 92-character native clipboard contents.rake formaton changed Rust files and--checkpassed; worktree-builtrake lintchecked 787 files with zero diagnostics. Full workspace builds were left to CI.Limits of verification:
navigator.clipboard.writeTextpayload was verified instead. Native clipboard readback passed.The target directory was deleted after builds. The worktree and verification logs remain locally. This PR is draft and must not be merged automatically.
🤖 Generated with Claude Code