Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps can keep small tokens in the system credential store through
Platform::secrets(app_id), with asynchronous read/write/delete requests. App ids and names map injectively onto separate URL keys; values have redacted Debug and zeroized owned buffers, and never register with inspection or storage tooling. Web explicitly fails without a storage fallback.Adds desktop demo controls, a restart/cleanup probe, redaction regressions and platform/error documentation. Missing reads return None and missing deletes succeed. Backend messages are withheld; typed errors are mapped where GPUI preserves them, with documented limits. Store encryption and biometric prompts remain out of scope.
The
devtools→dep:windowsaddition was incidental to the dependency edit; typed secrets errors requirewindowsthroughgpui, which already enables it, so the extradevtoolsedge is redundant.Closes #17
Verified on this Mac:
cargo build -p rake-app --example secrets-probeandcargo build -p rake-desktop-examplepassed.cargo test -p rake-app --lib platform::secrets: 4 passed, including backend-message redaction and typed macOS error mappings.cargo test -p rake-app --lib platform::secrets --no-default-features --features devtools: 2 passed, checking diagnostics, the formatted log tail used by file output, inspection output and the storage catalog.dev.rake.secrets-17-test/restart-probeentry, read it in a new process, checked missing reads and repeated deletion, and confirmed absence. Final cleanup succeeded; no test entry remains.rake format,rake lintand the dependency-pin/default-Web-graph check passed.Not verified: real Windows/Linux desktop keychains, Web runtime, interactive locked/denied prompts, or desktop button interactions. Typed error mappings use source contracts and synthetic tests; they do not establish real OS behavior. CI runs the wider platform matrix. The isolated target directory has been removed; the worktree and logs remain for review.
🤖 Generated with Claude Code