Repository navigation
Conversation
Build the X11 probe before starting its display and preserve connection diagnostics. Keep write serialization owned by blocking I/O so final shutdown can drain slow writes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lifecycle probe closes and reopens X connections. Keep Xvfb alive between clients so reconnects cannot race its automatic reset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Allow slow writes beyond the normal shutdown deadline, but warn and return if the disk remains stuck. Cover both a delayed write and a gate held until quit returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1bye
added a commit
that referenced
this pull request
Nov 21, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix X11 shortcut lifecycle reconnects and give native window placement a bounded final flush on quit.
-s '-screen 0 1280x800x24 -noreset'so the server stays ready between clients. The separate build step is a secondary fix: compilation no longer runs inside the display lifecycle. Preserve connection failures through the existing Native variant; only an unset display remains Unsupported. Capability detection stays boolean and public error mapping stays compatible.block_with_timeoutbudget. Warn and return on timeout. Move the serialization guard into blocking I/O and cancel the coalescing worker so completion does not need another UI task to run. Disk I/O remains off-thread; final placement can be lost if this longer budget expires.Evidence: X11 failure compiled inside xvfb-run, then reported Unsupported; the original mapping discarded the precise connect error. Source inspection confirms the repeated connection lifecycle responsible for the reset race. Windows failure raced the real write against GPUI’s shutdown deadline; removing randomized poll limits did not remove that deadline.
Validation: focused rake format passed; rake lint reported zero diagnostics. No local cargo build, test, or clippy commands run.
Final head:
943868821dc7ab0cd4a58c77346407cc55652c25.Initial run 44886486049: windows-tests 1/1 passed; desktop (ubuntu-24.04) 0/1 passed. Its shortcut lifecycle probe passed, and both window-state regression tests passed in all three Linux test configurations. The desktop job failed only in the separate real-frame smoke step:
Desktop smoke exceeded 60s; the app emitted startup and session-service warnings without a panic. Keep that failure visible; no smoke assertion or timeout was relaxed.Requested final-head reruns: windows-tests 0/3 completed; desktop (ubuntu-24.04) 0/3 completed. Rerun #1 requested as an independent full workflow dispatch on the same final head because the original run still has a native job in progress and the job-rerun command returned
job 136792888345 cannot be rerun. Two more full reruns will follow. Earlier passes on a2a3047 do not count toward this head.🤖 Generated with Claude Code