Repository navigation
fix(french/novelfrance): render inline italic tags instead of escaping them - #2834
Merged
rajarsheechatterjee merged 1 commit intoNov 7, 2026
Merged
Conversation
…g them Co-Authored-By: Claude <noreply@anthropic.com>
[Low impact] The PR appears safe to merge. SummaryNovelFrance now renders attribute-less inline formatting tags instead of showing them as text.
Reviews (1) · Last reviewed commit: "fix(french/novelfrance): render inline i..." · Reviewed by Greptile |
rajarsheechatterjee
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In NovelFrance 1.0.1, chapters show literal
<i>…</i>tags in the reader instead ofitalic text.
Repro: open "The Broken Halo", chapter 1 -> thoughts are displayed with visible
<i>/</i>.Cause
parseChapterruns every paragraph from the API (paragraphs[].content) throughescapeHtml. The API already sends inline markup (<i>…</i>), soescapeHtmlturns it into<i>…</i>.Fix
escapeHtmlrestores only attribute-less inline tags:i,em,b,strong,u.<script>,&, tags with attributes, ...), so no new HTMLinjection surface.
1.0.1->1.0.2.Testing
npm run check:plugin -- plugins/french/novelfrance.ts:popularNovelssearchNovelsparseNovelparseChapterthe-broken-halo/chapter-1): italic tags (<i>…</i>) are preserved as HTML markup instead of raw<i>text.escapeHtmlchecked in isolation:<i>x</i>kept,<script>escaped,&->&,<i onclick="…">stays escaped.npx prettier --check plugins/french/novelfrance.ts,npx eslint plugins/french/novelfrance.ts,npm run build:compile: OK.AI disclosure
The patch was drafted with help from Claude (AI assistant) and reviewed/tested by me.