From 68988ac2f283f6c3aa6e81c8f1126e6469428d57 Mon Sep 17 00:00:00 2001 From: Roman Zaiev Date: Tue, 10 Nov 2026 17:48:49 +0000 Subject: [PATCH 1/2] Release a version CHANGES.md names, whatever its date make release refused a commit whose CHANGES.md did not open with the version and today's date, so the version was named in a pull request of its own and renamed again when a release ran past midnight. It now checks the version alone, which the pull request that completes the release names, as Hypha's LIBRARY.md says. --- Makefile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 66237b3..e248ad7 100644 --- a/Makefile +++ b/Makefile @@ -58,8 +58,7 @@ db: ## start the test database db-down: ## stop and delete the test database podman compose rm -sf db -release: ## release VERSION, once CHANGES.md names it: open-opam tags it and makes its release - @test -n "$(VERSION)" || { echo "Give the version: make release VERSION=1.2.3" >&2; exit 2; } - @test "$$(git show HEAD:CHANGES.md | grep -m1 '^## ')" = "## $(VERSION) ($$(date +%F))" \ - || { echo "The commit to release must open CHANGES.md with ## $(VERSION) ($$(date +%F))" >&2; exit 2; } +release: ## tag VERSION and make its release + @test "$$(git show HEAD:CHANGES.md | grep -m1 '^## ' | cut -d' ' -f2)" = "$(VERSION)" \ + || { echo "CHANGES.md must open with ## $(VERSION)" >&2; exit 2; } open-opam release $(VERSION) From a057798b4f055793eb687070f7160b1edc51958f Mon Sep 17 00:00:00 2001 From: Roman Zaiev Date: Tue, 10 Nov 2026 18:00:25 +0000 Subject: [PATCH 2/2] Release by open-opam alone open-opam release already holds a commit to its CI and open-opam's gates before it tags it; the check of CHANGES.md's heading beside it added nothing a release needs. --- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index e248ad7..814b936 100644 --- a/Makefile +++ b/Makefile @@ -59,6 +59,4 @@ db-down: ## stop and delete the test database podman compose rm -sf db release: ## tag VERSION and make its release - @test "$$(git show HEAD:CHANGES.md | grep -m1 '^## ' | cut -d' ' -f2)" = "$(VERSION)" \ - || { echo "CHANGES.md must open with ## $(VERSION)" >&2; exit 2; } open-opam release $(VERSION)