From 71fdbed8f488cc78eab5d229dcba57d76f1147e0 Mon Sep 17 00:00:00 2001 From: Roly Gutierrez Date: Mon, 16 Nov 2026 16:14:50 -0400 Subject: [PATCH 1/2] fix(FOUR-26702): preserve ampersand in plain case titles from mustache fields Mustache HTML-escaping on case_title stored "&" as "&" when titles used dropdown values, breaking Core case review text display. Use identity escape for plain titles; keep htmlspecialchars on case_title_formatted for v-html list views. https://processmaker.atlassian.net/browse/FOUR-26702 --- ProcessMaker/Models/ProcessRequest.php | 8 +++++++- tests/unit/ProcessMaker/CaseTitleTest.php | 24 +++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/ProcessMaker/Models/ProcessRequest.php b/ProcessMaker/Models/ProcessRequest.php index 3424d0ab6f..173d9a81d1 100644 --- a/ProcessMaker/Models/ProcessRequest.php +++ b/ProcessMaker/Models/ProcessRequest.php @@ -1098,7 +1098,13 @@ public function evaluateCaseTitle(string $mustacheTitle, array $data, bool $form $len += mb_strlen($part); } } else { - $mustache = new MustacheExpressionEvaluator(); + $mustache = new MustacheExpressionEvaluator([ + 'escape' => function ($value) { + return is_scalar($value) || $value === null + ? (string) $value + : ''; + }, + ]); $title = $mustache->render($mustacheTitle, $data); // multi-byte 200 characters limit $title = mb_substr($title, 0, 200); diff --git a/tests/unit/ProcessMaker/CaseTitleTest.php b/tests/unit/ProcessMaker/CaseTitleTest.php index 6838a7d2f8..aa16ca6eb5 100644 --- a/tests/unit/ProcessMaker/CaseTitleTest.php +++ b/tests/unit/ProcessMaker/CaseTitleTest.php @@ -16,6 +16,18 @@ public function testEvaluateCaseTitleWithoutFormatting() $this->assertEquals('Hello, World!', $title); } + public function testEvaluateCaseTitleWithoutFormattingPreservesAmpersand() + { + $processRequest = new ProcessRequest(); + $title = $processRequest->evaluateCaseTitle( + 'Research {{department}}', + ['department' => 'Research & Development'], + false + ); + + $this->assertSame('Research Research & Development', $title); + } + public function testEvaluateCaseTitleWithFormatting() { $processRequest = new ProcessRequest(); @@ -24,6 +36,18 @@ public function testEvaluateCaseTitleWithFormatting() $this->assertEquals('Hello, World!', $title); } + public function testEvaluateCaseTitleWithFormattingEscapesAmpersandForHtml() + { + $processRequest = new ProcessRequest(); + $title = $processRequest->evaluateCaseTitle( + 'Research {{department}}', + ['department' => 'Research & Development'], + true + ); + + $this->assertSame('Research Research & Development', $title); + } + public function testEvaluateCaseTitleWithCharacterLimit() { $processRequest = new ProcessRequest(); From 75b948d3f7466e8040b6319975ab2f0181545763 Mon Sep 17 00:00:00 2001 From: Roly Gutierrez Date: Wed, 18 Nov 2026 11:12:59 -0400 Subject: [PATCH 2/2] refactor(FOUR-26702): extract formatted title truncation for Sonar Move the formatted case title 200-character loop into truncateFormattedCaseTitle to keep evaluateCaseTitle under the cognitive complexity limit (S3776). No behavior change. https://processmaker.atlassian.net/browse/FOUR-26702 --- ProcessMaker/Models/ProcessRequest.php | 48 +++++++++++++++----------- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/ProcessMaker/Models/ProcessRequest.php b/ProcessMaker/Models/ProcessRequest.php index 173d9a81d1..35c3a2b91d 100644 --- a/ProcessMaker/Models/ProcessRequest.php +++ b/ProcessMaker/Models/ProcessRequest.php @@ -1076,27 +1076,7 @@ public function evaluateCaseTitle(string $mustacheTitle, array $data, bool $form ]); $title = $mustache->render($mustacheTitle, $data); // multi-byte 200 characters limit - $titleParts = preg_split('/(|<\/b>)/', $title, -1, PREG_SPLIT_DELIM_CAPTURE); - $title = ''; - $size = 200; - $len = 0; - foreach ($titleParts as $i => $part) { - if ($part === '' || $part === '') { - $title .= $part; - continue; - } - if ($len + mb_strlen($part) >= $size) { - $part = mb_substr($part, 0, $size - $len); - $title .= $part; - $nextPart = $titleParts[$i + 1] ?? ''; - if ($nextPart === '') { - $title .= $nextPart; - } - break; - } - $title .= $part; - $len += mb_strlen($part); - } + $title = $this->truncateFormattedCaseTitle($title); } else { $mustache = new MustacheExpressionEvaluator([ 'escape' => function ($value) { @@ -1113,6 +1093,32 @@ public function evaluateCaseTitle(string $mustacheTitle, array $data, bool $form return $title; } + private function truncateFormattedCaseTitle(string $renderedTitle, int $size = 200): string + { + $titleParts = preg_split('/(|<\/b>)/', $renderedTitle, -1, PREG_SPLIT_DELIM_CAPTURE); + $title = ''; + $len = 0; + foreach ($titleParts as $i => $part) { + if ($part === '' || $part === '') { + $title .= $part; + continue; + } + if ($len + mb_strlen($part) >= $size) { + $part = mb_substr($part, 0, $size - $len); + $title .= $part; + $nextPart = $titleParts[$i + 1] ?? ''; + if ($nextPart === '') { + $title .= $nextPart; + } + break; + } + $title .= $part; + $len += mb_strlen($part); + } + + return $title; + } + public function isSystem() { $systemCategories = ProcessCategory::where('is_system', true)->pluck('id');