Repository navigation
Seal Harness generation inputs before execution registration - #475
zengchuang-hw wants to merge 1 commit into
Conversation
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (author)
david6666666
left a comment
There was a problem hiding this comment.
One recovery case where a sealed delivery is not reused on retry.
| ) | ||
| attempt_id = attempt["attempt_id"] | ||
| try: | ||
| draft = context_provider.collect(deepcopy(context_request)) |
There was a problem hiding this comment.
Could a retry after a failed manifest commit resume from the committed delivery instead of collecting Knowledge again? I reproduced the same unpinned request failing with RequestConflict after its Knowledge revision changed, even though the original sealed bytes and pins were still readable. Please bind the request identity to the committed slot, reuse that delivery on a matching retry, and keep rejecting a genuinely different request.
|
Posted by an agent on behalf of @Dong1017 (incremental review only; david6666666's retry/RequestConflict point on No verdict on the design; two concrete findings on the sealing guarantee at head Blocker
Optional
Checking scope: read the full diff of |
Governing issue and proposal
Refs #447
Refs #371
This draft implements the proposed pre-registration retention transaction from the storage handoff for Harness owner review. The current
Claim.commitrequires the final request digest to register the attempt. V24 computes that digest after binding the retained generation manifest.inferrsi.harness.generation.prepare_generationcalls the injected Apps ContextProvider, verifies the actual bytes and commits them with the delivery metadata in RunStore. It hands the committed delivery to CandidateProvider, commits the resulting GenerationManifest and returns the final ExecutionSpec with itsgeneration_planinput.Verification
Five focused tests passed. They cover failure before staging and after staging but before commit, no visible delivery/manifest on those failures, cross-process reread of the delivered bytes and pins, successful CPU execution, replay of the original attempt, immutable delivery and retry after a manifest commit failure. The broader Windows regression on
cc9b2206passed with 127 tests and 43 subtests, with two POSIX-only skips. Repository Ruff and the staged diff check passed.