From 231ba9d1f1f3c0e56205310d48bcd2d68fd5829a Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:24:21 +0100 Subject: [PATCH 1/8] use service container for mongodb on ubuntu runner the compose file approach did not work because the file path is evaluated in the comtext of the calling workflow workarounds are possible, but using services is probably cleaner --- .github/workflows/maven-verify.yml | 21 ++++++++++++--------- compose.mongo.yaml | 21 --------------------- 2 files changed, 12 insertions(+), 30 deletions(-) delete mode 100644 compose.mongo.yaml diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 63d9282..5397f8e 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -55,6 +55,18 @@ jobs: build: runs-on: ${{ inputs.runner }} + services: + mongodb: + if: inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') + image: mongo:8.2.12 # todo: use ${{ inputs.db-version }} when mongodb fixes incompatibility with linux kernel + # https://docs.docker.com/reference/cli/docker/container/create/#options + options: >- + --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\" || exit 1" + --health-start-interval: 3s + --health-start-period: 30s + ports: + - 27017:27017 + steps: - # https://github.com/actions/checkout name: Clone repository @@ -93,15 +105,6 @@ jobs: run: | ${{ inputs.db-version < 6 && 'mongo' || 'mongosh' }} --eval "db.version()" - - # on ubuntu we can simply use docker to set up mongodb - name: Set up MongoDB and check connection (ubuntu) - if: inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') - # todo: revert to ${{ inputs.db-version }} once mongodb fixes incompatibility with linux kernel - # https://jira.mongodb.org/browse/SERVER-125742 - run: | - export MONGO_VERSION=8.2.12 - docker compose -f compose.mongo.yaml up -d - - # https://github.com/actions/setup-java name: Setup Java uses: actions/setup-java@v6 diff --git a/compose.mongo.yaml b/compose.mongo.yaml deleted file mode 100644 index 18b0802..0000000 --- a/compose.mongo.yaml +++ /dev/null @@ -1,21 +0,0 @@ -# this file sets up mongodb for use in the maven-verify workflow -services: - mongo: - image: "mongo:${MONGO_VERSION}" - restart: no - ports: - - "127.0.0.1:27017:27017" - healthcheck: - test: | - [ $(mongosh --quiet --host localhost:27017 --eval "db.runCommand('ping').ok") = 1 ] || exit 1 - start_interval: 3s - start_period: 30s - mongosh: - image: alpine/mongosh - restart: no - depends_on: - mongo: - condition: service_healthy - command: - - mongosh - - --eval "db.version()" From 39053cde00eb0f06edbb4b53a342137f2b9b8b42 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:29:58 +0100 Subject: [PATCH 2/8] fix conditional service if condition is not supported in services, but docs say we can set empty image to prevent a service from starting --- .github/workflows/maven-verify.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 5397f8e..0880cb7 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -57,8 +57,10 @@ jobs: services: mongodb: - if: inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') - image: mongo:8.2.12 # todo: use ${{ inputs.db-version }} when mongodb fixes incompatibility with linux kernel + # set empty image to disable service, as described in docs: + # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idservicesservice_idimage + # todo: use ${{ inputs.db-version }} when mongodb fixes incompatibility with linux kernel + image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\" || exit 1" From 7ea3a207869b50eac55cf87a12c9f909365fec6c Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:42:22 +0100 Subject: [PATCH 3/8] explicit host in mongodb service health check --- .github/workflows/maven-verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 0880cb7..53db46c 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -63,7 +63,7 @@ jobs: image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- - --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\" || exit 1" + --health-cmd "mongosh --quiet --host localhost:27017 --eval \"db.adminCommand('ping')\" || exit 1" --health-start-interval: 3s --health-start-period: 30s ports: From 34bf30d897d319c914ad741b172c384557de1923 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:44:45 +0100 Subject: [PATCH 4/8] remove || exit 1 from mongodb service healthcheck --- .github/workflows/maven-verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 53db46c..f3b27bc 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -63,7 +63,7 @@ jobs: image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- - --health-cmd "mongosh --quiet --host localhost:27017 --eval \"db.adminCommand('ping')\" || exit 1" + --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\"" --health-start-interval: 3s --health-start-period: 30s ports: From aad11e9d4f20fb2ee3a0bd2af47fd580b463db17 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:54:06 +0100 Subject: [PATCH 5/8] try db.version() instead of db.adminCommand('ping') for mongodb service health check --- .github/workflows/maven-verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index f3b27bc..2ead496 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -63,7 +63,7 @@ jobs: image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- - --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\"" + --health-cmd "mongosh --quiet --eval 'db.version()'" --health-start-interval: 3s --health-start-period: 30s ports: From f25825e35fe80f79f6b21e9f349652df7163ba5a Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:59:31 +0100 Subject: [PATCH 6/8] Revert "try db.version() instead of db.adminCommand('ping') for mongodb service health check" This reverts commit aad11e9d4f20fb2ee3a0bd2af47fd580b463db17. --- .github/workflows/maven-verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 2ead496..f3b27bc 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -63,7 +63,7 @@ jobs: image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- - --health-cmd "mongosh --quiet --eval 'db.version()'" + --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\"" --health-start-interval: 3s --health-start-period: 30s ports: From 9032c39bddd4eb91f10c08dbdec57b31f188fbda Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 14:59:42 +0100 Subject: [PATCH 7/8] Revert "remove || exit 1 from mongodb service healthcheck" This reverts commit 34bf30d897d319c914ad741b172c384557de1923. --- .github/workflows/maven-verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index f3b27bc..53db46c 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -63,7 +63,7 @@ jobs: image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- - --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\"" + --health-cmd "mongosh --quiet --host localhost:27017 --eval \"db.adminCommand('ping')\" || exit 1" --health-start-interval: 3s --health-start-period: 30s ports: From 77ac3894b3def698d18304761ea371420d44a7e3 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 10 Nov 2026 15:01:16 +0100 Subject: [PATCH 8/8] remove unsupported --health-start-* options --- .github/workflows/maven-verify.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index 53db46c..0cb880e 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -63,9 +63,7 @@ jobs: image: ${{ inputs.db-type == 'mongodb' && startsWith(inputs.runner, 'ubuntu') && 'mongo:8.2.12' || '' }} # https://docs.docker.com/reference/cli/docker/container/create/#options options: >- - --health-cmd "mongosh --quiet --host localhost:27017 --eval \"db.adminCommand('ping')\" || exit 1" - --health-start-interval: 3s - --health-start-period: 30s + --health-cmd "mongosh --quiet --eval \"db.adminCommand('ping')\" || exit 1" ports: - 27017:27017